Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Support for CMS 6 #81

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

emteknetnz
Copy link
Member

job_creator.php Outdated Show resolved Hide resolved
Comment on lines +45 to +47
'8.1',
'8.2',
'8.3',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll only support 8.3 to start with - but I guess we can remove this when we bump the PHP dep so no change required for this just yet, just thinking aloud.

job_creator.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/1.12/cms6 branch 2 times, most recently from a779f0d to d12eb3b Compare February 22, 2024 00:39
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@GuySartorelli GuySartorelli merged commit 28bfcf2 into silverstripe:1.12 Feb 22, 2024
4 checks passed
@GuySartorelli GuySartorelli deleted the pulls/1.12/cms6 branch February 22, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants